Minor fixes: gxpkg, std/text/char-set, README #1023
Conversation
✅ Deploy Preview for elastic-ritchie-8f47f9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/tools/gxpkg.ss
Outdated
| (def prefix (or package-prefix | ||
| (getenv "USER" #f) | ||
| (begin (eprintf "Package prefix not specified with -p or --package, and USER not defined\n") | ||
| (exit 2)))) |
There was a problem hiding this comment.
that's a little rude.
I think we should just raise an error with the informative message, instead of print and exit.
There was a problem hiding this comment.
I think there should be an (abort ...) primitive that throws an error that is specially caught by the runtime to print a message and exit without a stack trace (unless stack trace is specifically requested by a parameter typically set from a command-line option).
See :clan/exit for some of the beginnings of that.
Until then, what should we do?
There was a problem hiding this comment.
Just error it and we can add abort to std/error
There was a problem hiding this comment.
Where in the runtime is the right place to add the stuff in clan/exit ?
There was a problem hiding this comment.
It doesn't need to be in runtime, we jist need an Exception object that defines display-exception, it can live in std/error.
No description provided.